Skip to content

[MachO] Tweak handling of LC_FUNCTION_STARTS #7432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdash merged 1 commit into from
Oct 2, 2025
Merged

[MachO] Tweak handling of LC_FUNCTION_STARTS #7432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions view/macho/machoview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,8 @@ bool MachoView::IsValidFunctionStart(uint64_t addr)
const auto& instr = ilFunc->GetInstruction(i);
if (instr.operation == LLIL_UNDEF)
return false;
if (i == 0 && instr.operation == LLIL_TRAP)
return false;
}

return true;
Expand Down Expand Up @@ -993,12 +995,12 @@ void MachoView::ParseFunctionStarts(Platform* platform, uint64_t textBase, funct
uint64_t target = curfunc;
if (!IsValidFunctionStart(target))
{
m_logger->LogWarn("Possible error processing LC_FUNCTION_STARTS! Not adding function at: 0x%" PRIx64 "\n", target);
m_logger->LogInfoF("Address {:#x} referenced from LC_FUNCTION_STARTS does not appear to be a function", target);
continue;
}
Ref<Platform> targetPlatform = platform->GetAssociatedPlatformByAddress(target);
AddFunctionForAnalysis(targetPlatform, target);
m_logger->LogDebug("Adding function start: %#" PRIx64 "\n", curfunc);
m_logger->LogDebugF("Adding function start: {:#x}", curfunc);
}
}
catch (ReadException&)
Expand Down
Loading