fix(markdown): resolve optional token threshold defaults - #543
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The public
pageindex.md_to_tree()API defaults both optional token thresholds toNone. Enabling summaries or thinning without explicitly supplying a threshold compares an integer token count againstNoneand raisesTypeError, before summaries can be generated.Change
Resolve omitted or explicit
Nonethresholds to the CLI's existing defaults: 200 summary tokens and 5,000 thinning tokens. Preserve explicit zero and positive thresholds.Validation
python -m pytest -q— 589 passed, 218 skipped, 6 subtests passed on Python 3.12.14/PDFium 5.13.0, without optional agent frameworks.The hosted Python 3.10/3.13 and optional-framework/PDFium matrix remains for upstream CI; the local result does not claim that matrix passed.
Prepared with AI assistance; source, reproductions and exact patch were independently reviewed.