Repository navigation
Reuse axis candidate storage and transfer prepared segment spans - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A horizontal-axis cache miss creates and destroys its tick-candidate vector for each density level. Preparing a built-in line or area also copies the newly computed segment-span vector into the draw-command handoff even though the preparation code can read the transferred storage.
Change
These are local ownership and allocation changes; tick selection, formatting, sample segmentation, and draw ordering remain the same. The likely benefits are axis-cache misses and discontinuous line/area frames. End-to-end gains have not been measured.
Validation
LayoutCalculatorandSampleUploadReusetest coverage.Before marking ready
Run
LayoutCalculatorandSampleUploadReusein the supported QRhi configurations, and measure an axis-cache-miss/segmented-series workload against the baseline. This PR is a draft pending native and performance evidence.Independent review
Fresh-context independent source review found no remaining code blocker in this exact candidate. Native tests and representative application performance evidence remain pending as described above.