Repository navigation
Reuse main LOD scales for matching series previews - #26
Merged
Merged
Conversation
A preview that matches its main series currently copies the main LOD scale vector even though the planner accepts it by const reference and the main vector remains alive throughout both calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A preview that matches its main series currently copies the main LOD scale vector even though the planner accepts it by const reference and the main vector remains alive throughout both calls.
Changes
Validation
These are retained results for the unchanged candidate; task-start checks confirm its base files still match GitHub master. An independent source review found no blocker.
The configured public PR workflows passed as recorded below; existing preview/planner coverage remains authoritative.
Evidence limits
Qt6_FOUND=0); native build/test evidence comes from the published CI runs below. No local GPU or application performance run is claimed.Published native CI
Automatic pull-request workflows passed for published head
4f6aaa958137c09377c8ff968547a254d6cd1c50:These workflow results supplement the retained helper probes above. Representative application/rendering performance qualification remains outstanding.