Repository navigation
Unify plot test declarations, deployment, and summaries - #23
Merged
Merged
Conversation
Plot test targets, CTest registration, Windows deployment and configure summaries were maintained independently. The runtime list duplicated the shader-reference target, and the summary omitted the QML module test. Extend the existing local helper to create and register each executable, preserving its CTest name and linked component while recording the target inventory. Use that inventory for Windows deployment and summaries; leave exceptional dependencies and PackageSmoke handling intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The test CMake file maintained separate target, registration, runtime-deployment and summary inventories. They had drifted: the shader-reference runtime target was repeated and the QML module test was omitted from the printed summary.
Changes
Extend the existing local helper to create and register each executable and record its runtime needs. Derive deployment and summary entries from those declarations. Preserve CTest display names and order, optional text and Qt Quick conditions, source files, exceptional dependencies, test environment, and PackageSmoke viability/commands. Net reduction: 117 lines.
Validation
Eight evaluation-only CMake metadata comparisons preserve registration and target metadata across text ON/OFF, top-level/embedded, and Qt Quick present/absent modes. The Windows cases preserve the unique deployment target set and remove its duplicate; summaries cover every configured executable.
git diff --checkpasses.This metadata probe uses dependency placeholders and does not claim native build or runtime coverage. The public Linux and Windows text ON/OFF CI jobs are the native gate; keep draft until they pass.