Update install-macos.sh - #89
Open
maumeerally wants to merge 1 commit into
Open
Conversation
Author
|
@SW386 Bringing this pull request to your attention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added defensive double-quoting around variable references throughout the script. This follows ShellCheck best practices to prevent word-splitting, unexpected glob expansion, and syntax errors if file paths, URLs, or command outputs contain spaces or special characters.
Specific changes made:
⚬ File Path Quoting ($PKG_PATH): Enclosed $PKG_PATH in double quotes ("$PKG_PATH") across all file operation commands (rm, curl, shasum, pkgutil, and installer).
⚬ URL Quoting ($PKG_URL): Wrapped "$PKG_URL" in double quotes in the curl download step.
⚬ Safe Variable Comparison: Updated the checksum equality test from if [ $downloaded_checksum = $CHECKSUM ] to if [ "$downloaded_checksum" = "$CHECKSUM" ]. This prevents bash [: too many arguments syntax crashes if $downloaded_checksum evaluates to empty or contains whitespace.