fix: explicit env var passthrough for sudo on env_reset distros - #87
Closed
murilovarela wants to merge 1 commit into
Closed
fix: explicit env var passthrough for sudo on env_reset distros#87murilovarela wants to merge 1 commit into
murilovarela wants to merge 1 commit into
Conversation
On distros with env_reset in sudoers (RHEL, Fedora, Amazon Linux, etc.), sudo -E does not reliably pass through VANTA_KEY, VANTA_OWNER_EMAIL, or VANTA_REGION to the dpkg/rpm postinst. Replace sudo -E with plain sudo and forward only the required vars explicitly via sudo env. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
murilovarela
marked this pull request as ready for review
June 11, 2026 14:31
anani112
previously approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On distros with
env_resetin sudoers (like we've seen in Ubuntu 26.04 as reported: https://vanta.atlassian.net/browse/PER-10076),sudo -Edoes not reliably pass throughVANTA_KEY,VANTA_OWNER_EMAIL, orVANTA_REGION. Theenv_resetpolicy strips the environment regardless of the-Eflag, so thedpkg/rpmpostinst script never sees the required variables and installation fails silently.Solution
Replace
sudo -Ewith plainsudoand explicitly forward only the required variables viasudo env VAR=value .... This sidestepsenv_resetentirely — the variables are passed as arguments toenvrather than inherited through sudo.VANTA_NOSTARTis forwarded conditionally using shell parameter expansion so it is only included when set.Changes
install-linux.sh: Replacesudo -Ewithsudoand pass env vars explicitly to the install commandFixes PER-10076