Remote play Intel + NVIDIA prop fixes#2271
Open
matte-schwartz wants to merge 2 commits into
Open
Conversation
Screenshot textures created in vulkan_acquire_screenshot_texture() were missing bSampled, so no sampled image view was set up for the RGB-to-NV12 conversion shader. The result was a black PipeWire frame during e.g. Steam Remote Play. Affects both Intel and NVIDIA hardware.
XRGB2101010 storage images are an optional Vulkan feature that the NVIDIA proprietary driver doesn't implement, so imageStore writes land in XBGR order and PipeWire NV12 capture and AVIF screenshots get red and blue swapped. Query the format features once, capture as XBGR2101010 when XRGB2101010 lacks linear storage/sampled support, and unpack screenshot pixels according to the texture's actual format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes: #2094
@cmspam I've replaced the driver matching with a more generic solution here, which I think makes a bit more sense. I confirmed it also fixes the issue on my RTX 5090 without regressing AMD or Intel.