Bugfix: dtype_to_pxp_element failures due to endianness - #162
Open
pressler-vsc wants to merge 1 commit into
Open
Bugfix: dtype_to_pxp_element failures due to endianness#162pressler-vsc wants to merge 1 commit into
pressler-vsc wants to merge 1 commit into
Conversation
pressler-vsc
requested review from
bombaci-vsc,
dhaverporth,
johnstob,
mstewart-vsc and
mtrachy
August 25, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where
sarkit.cphd.dtype_to_pvp_elementincorrectly rejects pxp dtypes if their endianness is not native. This can be reproduced by running the new tests using main on a little-endian system: