Skip to content

Bugfix: Accommodate Tx antenna PVPs with NaNs in cphdcheck #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pressler-vsc merged 1 commit into from
Jul 31, 2026
Merged

Bugfix: Accommodate Tx antenna PVPs with NaNs in cphdcheck #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- Warnings logged when not all CRSD support arrays written
- Allow NaN in TxACX, TxACY, TxEB PVPs to indicate no transmit pulse for the vector


## [1.10.0] - 2026-06-25
Expand Down
18 changes: 12 additions & 6 deletions sarkit/verification/_cphd_consistency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,13 +925,17 @@ def check_tx_acxy(self, channel_id, channel_node):
pvp = self._get_channel_pvps(channel_id)
assert {"TxACX", "TxACY"}.issubset(pvp.dtype.names)
with self.need("TxACX is unit length"):
assert np.linalg.norm(pvp["TxACX"], axis=-1) == con.Approx(1.0)
assert np.nan_to_num(
np.linalg.norm(pvp["TxACX"], axis=-1), nan=1.0
) == con.Approx(1.0)
with self.need("TxACY is unit length"):
assert np.linalg.norm(pvp["TxACY"], axis=-1) == con.Approx(1.0)
assert np.nan_to_num(
np.linalg.norm(pvp["TxACY"], axis=-1), nan=1.0
) == con.Approx(1.0)
with self.need("TxACX and TxACY are orthogonal"):
assert np.vecdot(pvp["TxACX"], pvp["TxACY"]) == con.Approx(
0.0, atol=1e-6
)
assert np.nan_to_num(
np.vecdot(pvp["TxACX"], pvp["TxACY"]), nan=0.0
) == con.Approx(0.0, atol=1e-6)

@per_channel
def check_txeb(self, channel_id, channel_node):
Expand All @@ -940,7 +944,9 @@ def check_txeb(self, channel_id, channel_node):
pvp = self._get_channel_pvps(channel_id)
assert "TxEB" in pvp.dtype.names
with self.need("TxEB is less than unit length"):
assert np.linalg.norm(pvp["TxEB"], axis=-1) <= con.Approx(1.0)
assert np.nan_to_num(
np.linalg.norm(pvp["TxEB"], axis=-1), nan=0.0
) <= con.Approx(1.0)

@per_channel
def check_rcv_acxy(self, channel_id, channel_node):
Expand Down
Loading