fix: Filtered SSIDs persist in time graph legend#610
Open
mdrkrg wants to merge 2 commits into
Open
Conversation
The DataManager now uses the Predicate to determine which difference-series entries and active cache entries are legitimate (temporarily out of range) vs filtered out. This prevents filtered SSIDs from persisting in the time graph legend after a filter is applied.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
=========================================
Coverage 97.83% 97.83%
Complexity 975 975
=========================================
Files 121 121
Lines 2581 2585 +4
Branches 211 211
=========================================
+ Hits 2525 2529 +4
Misses 19 19
Partials 37 37 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this implement/fix?
This PR adds two test cases in
DataManagerTest.ktthat fail:newSeriesShouldNotIncludeActiveCacheEntriesNotInCurrentWiFiDetails-- verifies thatnewSeries()excludes cached entries that do not match the applied filter predicate.adjustDataShouldNotAppendToStaleCacheEntriesNotInCurrentDetails-- verifies thatadjustData()does not append floor-level data points or increment TimeGraphCache counters for entries that do not match the predicate.The bug: when a user navigates directly to the time graph and enables an SSID filter,
DataManager.newSeries()unconditionally mergestimeGraphCache.active()entries into the return set. SinceremoveSeries()only removes series not in this set, filtered-out SSIDs remain visible for up toMAX_NOT_SEEN_COUNT(20) scans.Does this close any issues?
None.
How was this tested?
Checklist (required before marking ready)
app/src/test/)AI Assistance
Additional context
None.
Reviewer notes
None.