v492.0 dev6#34
Merged
Merged
Conversation
67 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release-test tooling for EventDisplay v492 by removing hard-coded local paths, making ROOT macros/scripts more environment-driven and robust, and refreshing Crab runlists for 2026-era processing.
Changes:
- Add reusable helpers to load
libVAnaSum.sofrom environment and to construct standard Crab anasum paths from version/cut. - Update Crab plotting macros to use the new helpers (no hard-coded AFS paths) and extend sensitivity plotting to support version-to-version comparisons.
- Fix small script bugs (typos/variable usage, cut-alias parsing robustness), update output directory naming, refresh runlists, and adjust README links.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| release_tests/utilities/parameters.C | Adds loadVAnaSumLibrary() and getCrabAnasumPath() helpers used by ROOT macros. |
| release_tests/sources/Crab/runlist_releaseTestingV6redHV.dat | Appends new Crab runs for redHV. |
| release_tests/sources/Crab/runlist_releaseTestingV6.dat | Appends additional Crab runs for 2026 lists. |
| release_tests/sources/Crab/runlist_generator_from_anasum_log.sh | Fixes wobble default assignment typo (WOBB). |
| release_tests/sources/Crab/plot_skymaps.C | Switches to correct utilities include path and uses loadVAnaSumLibrary(). |
| release_tests/sources/Crab/plot_sensitivity.C | Removes hard-coded version paths; adds parameters for version/comparison version. |
| release_tests/sources/Crab/plot_sensitivity_compare_cuts.C | Parameterizes versions and uses standard anasum path construction (plus optional reference curve). |
| release_tests/sources/Crab/plot_lightcurves.C | Switches to correct utilities include path and uses loadVAnaSumLibrary(). |
| release_tests/sources/Crab/plot_energy_spectra.C | Switches to correct utilities include path and uses loadVAnaSumLibrary(). |
| release_tests/sources/Crab/anasum_from_runlists.sh | Makes CUT alias extraction explicit/validated to avoid mixing naming schemes. |
| release_tests/montecarlo/mc_data_comparison/compareDatawithMC.sh | Fixes atmosphere-selection conditional to use the correct variable. |
| release_tests/montecarlo/energythresholds/plot.C | Updates output directory naming to match EventDisplay_Release_<version> convention. |
| README.md | Updates repository links/naming (currently with a markdown issue). |
| .pre-commit-config.yaml | Bumps black hook revision. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following updates: