Skip to content

v492.0 dev6#34

Merged
GernotMaier merged 9 commits into
mainfrom
v492.0-dev6
May 31, 2026
Merged

v492.0 dev6#34
GernotMaier merged 9 commits into
mainfrom
v492.0-dev6

Conversation

@GernotMaier
Copy link
Copy Markdown
Member

@GernotMaier GernotMaier commented May 28, 2026

Following updates:

@GernotMaier GernotMaier self-assigned this May 28, 2026
@GernotMaier GernotMaier marked this pull request as ready for review May 31, 2026 18:43
@GernotMaier GernotMaier requested a review from Copilot May 31, 2026 18:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release-test tooling for EventDisplay v492 by removing hard-coded local paths, making ROOT macros/scripts more environment-driven and robust, and refreshing Crab runlists for 2026-era processing.

Changes:

  • Add reusable helpers to load libVAnaSum.so from environment and to construct standard Crab anasum paths from version/cut.
  • Update Crab plotting macros to use the new helpers (no hard-coded AFS paths) and extend sensitivity plotting to support version-to-version comparisons.
  • Fix small script bugs (typos/variable usage, cut-alias parsing robustness), update output directory naming, refresh runlists, and adjust README links.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
release_tests/utilities/parameters.C Adds loadVAnaSumLibrary() and getCrabAnasumPath() helpers used by ROOT macros.
release_tests/sources/Crab/runlist_releaseTestingV6redHV.dat Appends new Crab runs for redHV.
release_tests/sources/Crab/runlist_releaseTestingV6.dat Appends additional Crab runs for 2026 lists.
release_tests/sources/Crab/runlist_generator_from_anasum_log.sh Fixes wobble default assignment typo (WOBB).
release_tests/sources/Crab/plot_skymaps.C Switches to correct utilities include path and uses loadVAnaSumLibrary().
release_tests/sources/Crab/plot_sensitivity.C Removes hard-coded version paths; adds parameters for version/comparison version.
release_tests/sources/Crab/plot_sensitivity_compare_cuts.C Parameterizes versions and uses standard anasum path construction (plus optional reference curve).
release_tests/sources/Crab/plot_lightcurves.C Switches to correct utilities include path and uses loadVAnaSumLibrary().
release_tests/sources/Crab/plot_energy_spectra.C Switches to correct utilities include path and uses loadVAnaSumLibrary().
release_tests/sources/Crab/anasum_from_runlists.sh Makes CUT alias extraction explicit/validated to avoid mixing naming schemes.
release_tests/montecarlo/mc_data_comparison/compareDatawithMC.sh Fixes atmosphere-selection conditional to use the correct variable.
release_tests/montecarlo/energythresholds/plot.C Updates output directory naming to match EventDisplay_Release_<version> convention.
README.md Updates repository links/naming (currently with a markdown issue).
.pre-commit-config.yaml Bumps black hook revision.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread README.md Outdated
GernotMaier and others added 2 commits May 31, 2026 21:09
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@GernotMaier GernotMaier merged commit 852bbce into main May 31, 2026
1 check passed
@GernotMaier GernotMaier deleted the v492.0-dev6 branch May 31, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants