Starter move struct - #423
Conversation
…oves that AddUniqueStarterMoveTo pulls from
…mean the comments aren't right...?
…p your mind format-check, lol
| The moves are as follows: | ||
| - Vulpix: Faint Attack | ||
| - Eevee: Flail | ||
| - Phanphy: Ancient Power |
There was a problem hiding this comment.
Nitpick: it's spelled "Phanpy", and "AncientPower" is one word in Gen 4.
There was a problem hiding this comment.
Ah, my bad. Good catch!
…ueStarterMoveTo and the array it references.
I am quite silly, and only just realized that, indeed, as a few people have told me, these moves are egg moves from the respective pokemon's lines. Clarified comments around the function and the array it references, and re-named the function and the data-type of the array (if that's okay)
| NA: 0x20B3224 | ||
| JP: 0x20B4A98 | ||
| description: "[Runtime] The current PRNG sequence number for the system PRNG. See rand for more information on how the system PRNG works." | ||
| description: "[Runtime] The current PRNG sequence number for the system PRNG. See rand for more information on how the system PRNG works." No newline at end of file |
There was a problem hiding this comment.
Keep the newline at the end of the file
| NA: 0x2053568 | ||
| description: |- | ||
| Grants certain starter Pokemon a unique move that they cannot normally learn. | ||
| Grants certain starter pokemon an egg move from their line at the beginning of the game, adding it to the first available slot. |
There was a problem hiding this comment.
Nit: I won't be picky about the accent, but "Pokemon" should still be capitalized
| }; | ||
| ASSERT_SIZE(struct effect_control, 10148); | ||
|
|
||
| // Stores a pair of monster_id_16 to move_id_16, used for granting specific starter pokemon an egg move from their line. |
There was a problem hiding this comment.
This line is too long, it should be broken up into multiple lines.
In the future if you aren't sure what the formatter is complaining about, you can always download the properly formatted file from the format job that runs if the corresponding format-check fails (this is true for both symbols and headers).
There was a problem hiding this comment.
Thanks! I'll keep that in mind
3 participants
Upon recommendation, defined a struct for the array of moves read by AddUniqueStarterMoveTo, provided its (only NA) address, and fully documented both of these, including some very interesting notes about the choice of starters given unique moves in vanilla.
To avoid being too verbose, it may be worth removing the comment listing the moves given from AddUniqueStarterMovesTo, and instead only have it attached to this array.
I think it may also be worth researching whether these moves will "stick"– as in, if they're forgotten by any method, if they can be re-learned at the Electrivire Link Shop. The assembly behind that specific part of the game is still dizzying to me, so I haven't manged to glean too much regarding that myself.