feat: add setting for max_abstract_length - #1851
Open
zacharyjhankin wants to merge 3 commits into
Open
zacharyjhankin wants to merge 3 commits into
zacharyjhankin wants to merge 3 commits into
Conversation
zacharyjhankin
requested review from
SourangshuSTFC,
jkramya and
joeshannon
and removed request for
a team
October 1, 2026 14:32
| const MAX_TITLE_LEN = 175; | ||
| const MAX_ABSTRACT_LEN = 1500; | ||
|
|
||
| export const generalInfoUpdateValidationSchema = Yup.object().shape({ |
Contributor
There was a problem hiding this comment.
Would it worth keeping this extra validation, just for safety?
Collaborator
Author
There was a problem hiding this comment.
My understanding is that this isn't used anywhere, and if it was started to be used then it would potentially be wrong if the settings were changed. But I could be missing something if it is used by something?
Collaborator
Author
There was a problem hiding this comment.
I couldn't get this function to update to be accurate with the settings either because the validation doesn't have access to the context. Unless you pass it in, but that just seems excessive for a function that isn't used
Scott-James-Hurley
approved these changes
Oct 2, 2026
jkramya
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new setting that sets the max abstract length, it will be set to 1500 by default for everyone.
Motivation and Context
At diamond we have a max of 900 characters for our abstract length in our old system, as the UOS is 1500 that causes incompatibility between our two systems. I chose not to let it be configurable via the template because then each proposal template would have different places to set it, when we want one value for the entire system that will rarely/never change.
How Has This Been Tested
Fixes
Changes
Depends on
Tests included/Docs Updated?