fix: technique proposal rejection comment set before proposal status change

[ellen-wright]

Description

As part of UserOfficeProject/issue-tracker#1533

Motivation and Context

The comment that can be set by a scientist when a technique proposal's status is set to 'Unsuccessful' was not being populated correctly in the status action emails sent upon status change.

Fixes

The order of the comment being set in the database and the status being changed in the workflow (therefore sending any status action emails) has been switched to make sure the comment is available to be sent in the 'Unsuccessful' email to users.

Tests included/Docs Updated?

• I have added tests to cover my changes.
• All relevant doc has been updated

[mutambaraf]

On this line

user-office-core/apps/backend/src/datasources/postgres/ProposalInternalCommentsDataSource.ts

Line 63 in 80281b8

async createRejectionComment(

we can also update it so we only insert if delete is sucessfull `async createRejectionComment(
args: CreateProposalInternalCommentArgs
): Promise {
try {
const [proposalRejectionComment]: ProposalInternalCommentRecord[] =
await database.transaction(async (trx) => {
await trx(
'proposal_rejection_comments'
)
.where('proposal_pk', args.proposalPk)
.del();

      return trx('proposal_rejection_comments')
        .insert({
          proposal_pk: args.proposalPk,
          comment: args.comment,
        })
        .returning('*');
    });
  if (!proposalRejectionComment) {
    throw new GraphQLError(
      'Proposal rejection comment could not be created'
    );
  }

  return createProposalInternalCommentObject(proposalRejectionComment);
} catch (error) {
  logger.logException(
    `Could not create proposal rejection comment with args: '${JSON.stringify(args)}'`,
    error
  );
  throw new GraphQLError('Error while creating proposal rejection comment');
}

}`

[jekabs-karklins]

suggestion: Can we move the args into the context parameter? The reason is that we would like to use the exception title for aggregation, i.e. no dynamic values in the title.

Suggested change

	logger.logException(
	`Could not create proposal rejection comment with args: '${JSON.stringify(args)}'`,
	error
	);
	throw new GraphQLError('Error while creating proposal rejection comment');
	logger.logException(
	`Could not create proposal rejection comment`,
	error,
	args
	);
	throw new GraphQLError('Error while creating proposal rejection comment');

[jekabs-karklins]

Just a small comment

[jekabs-karklins]

💯

[mutambaraf]

LGTM

[mutambaraf]

We may need to use primaryKey instead of unsuccessfullPK.