Skip to content

Jazz config#44

Merged
marceloams merged 6 commits into
UselessCo:developfrom
APT-KK:jazz-config
Oct 21, 2025
Merged

Jazz config#44
marceloams merged 6 commits into
UselessCo:developfrom
APT-KK:jazz-config

Conversation

@APT-KK

@APT-KK APT-KK commented Oct 19, 2025

Copy link
Copy Markdown
Contributor

Pull Request

Type of Change

  • Bug fix
  • New feature
  • Sound contribution
  • Configuration contribution
  • Documentation update
  • Other (specify)

Description

add jazz yaml

Related Issue

Closes #(issue number)

Changes Made

  • Change 1
  • Change 2
  • Change 3

For Sound Contributions

  • Sound is in MP3 format
  • File size is under 500KB
  • Added sound to assets/sounds/
  • Created/updated config that uses the sound

For Code Changes

  • Code follows project style
  • No console.log in production code
  • All imports have .js extensions
  • Tested locally
  • Updated documentation if needed

Screenshots/Audio

If applicable, add screenshots or audio samples (Optional: SoundCloud, YouTube, etc.).

Checklist

  • My code/contribution follows the project guidelines
  • I have tested my changes
  • I have updated documentation as needed
  • My changes don't break existing functionality

@marceloams

Copy link
Copy Markdown
Contributor

Hey @APT-KK! A couple of things:

Sound size: We have a 500KB max limit. Please compress your sound to under 500KB (or replace it if needed), then push the update.

README: We don't need configs/README.md updated, it's a general informative file we keep unmodified to avoid PR conflicts. Please revert those changes.

Thanks!

@APT-KK

APT-KK commented Oct 20, 2025

Copy link
Copy Markdown
Contributor Author

i thinks its ready to merge now , I've fixed the issues, thanks!

@APT-KK

APT-KK commented Oct 20, 2025

Copy link
Copy Markdown
Contributor Author

@marceloams

@marceloams

Copy link
Copy Markdown
Contributor

Hey @APT-KK! Just need one small fix, please revert the README changes. Thanks!

@marceloams marceloams mentioned this pull request Oct 21, 2025
19 tasks
@APT-KK

APT-KK commented Oct 21, 2025

Copy link
Copy Markdown
Contributor Author

fixed it thank you

marceloams
marceloams previously approved these changes Oct 21, 2025
@APT-KK
APT-KK dismissed marceloams’s stale review October 21, 2025 16:41

The merge-base changed after approval.

@marceloams
marceloams merged commit f2ea9bd into UselessCo:develop Oct 21, 2025
11 checks passed
@marceloams

Copy link
Copy Markdown
Contributor

@APT-KK Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants