Honor OAuth resource metadata challenges - #1981
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 7f70971 | Commit Preview URL Branch Preview URL |
Sep 12 2026, 06:54 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 7f70971 | Sep 12 2026, 06:55 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
September 14, 2026 04:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP OAuth discovery ignored the endpoint's Bearer
resource_metadatachallenge and tried a guessed well-known path first. When those documents advertise different resource identifiers, authorization targets the wrong resource and can fail withinvalid_target.Follow the advertised metadata URL first, retaining path/origin discovery when no URL is advertised. Reuse the existing authentication-challenge parser, validate advertised URLs, keep resource credentials on their origin, and close header-only probe requests with their scope.
Validation: 56 focused SDK tests; SDK typecheck; repository formatting and lint; direct discovery against a live MCP provider. Hosted-emulator browser regression passed on this commit (1 test): correct resource, consent callback, and successful token exchange. The emulator consent form omits its login field, so the test submits the synthetic account through the emulator HTTP form contract. Full CI remains pending.