Add new protos and proper documentation for them - #12
Open
djpanther78 wants to merge 4 commits into
Open
Conversation
…by adding ROTOMPROTOS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As PR #10 suggested, a new login method called
NIANTIC_JWTneeds to be added to support the new Niantic Kids authentication flow, by @jfberry .Then @Furtif added that adding
[deprecated = true];to the already deprecated protos might be a good idea.To properly explain this Furtif created PR #11 to do this. In the process he also corrected
N_KIDStoSUPER_AWESOMEto preserve it in a more helpful way and added a detailed explanation to the protos by using comments.I had the idea to merge these two together into one PR that does both, but instead of adding comments to the protos, adding them to a new
documentation/folder to allow for more documentation in the future and keeping the protos clean.Please let me know if I need to add/remove/correct anything.
Again, credits to Jabes and Furtif!