feat: parse temp evolution branch quest rewards - #382
Merged
Conversation
ccev
reviewed
Jul 11, 2026
| if branch := info.GetTempEvoPokemonBranch(); branch != nil { | ||
| infoData["pokemon_id"] = int(branch.PokedexId) | ||
| if tempEvolution := int(branch.TempEvoId); tempEvolution != 0 { | ||
| infoData["temp_evolution"] = tempEvolution |
Collaborator
There was a problem hiding this comment.
Naming is a bit inconsistent across Golbat, but I'd prefer temp_evolution_id as the name (i don't care too much tho)
Collaborator
ReactMap depends on Golbat, not the other way around. This PR does not have to be a draft. I'm running this now |
Contributor
Author
|
Don't read too much into that. It's GPT written. 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pogo/vbase.pb.gofrom feat: add super mega eligible field to gym #360TEMP_EVO_BRANCH_RESOURCE(quest reward type 20) intoamount,pokemon_id, and optionaltemp_evolutionfieldsWhy
The protobuf bundled on
maindoes not define reward type 20 or its field-24 payload. Golbat therefore preserves the numeric reward type but emits an emptyinfoobject and cannot populate the indexed reward details.This keeps the upstream reward type truthful rather than rewriting type 20 as the older generic mega-resource type 12.
ReactMap coordination
WatWowMap/ReactMap@8756f38f currently normalizes only the old empty type-20 payload through a temporary Mewtwo fallback. Once Golbat emits populated type-20 details, ReactMap needs a companion change that consumes those details as mega energy while retaining the empty-payload fallback for older Golbat deployments.
Keep this PR in draft until that consumer-side handling is ready if ReactMap compatibility is required for deployment.
Validation
go test ./...golangci-lint v2.12.2 run- 0 issues