fix(schema): require the actions map to be non-empty - #669
Open
vishkaty wants to merge 1 commit into
Open
Conversation
overview.md states the Business MUST include every outstanding Action and MUST
omit `actions` when none are outstanding, but common/types/actions.json placed
no `minProperties` on the map (only `minItems: 1` on the array values), so an
empty `"actions": {}` validated while violating the MUST. Add
`minProperties: 1` so a schema-driven validator catches the empty map; the map
should be absent, not empty, when there is no outstanding work.
No example emits an empty actions map, so the full corpus is unaffected (282
passed, ucp-schema lint clean).
damaz91
added
the
status:needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docs/specification/overview.mdrequires the Business to omit theactionsmap when nothing is outstanding:But
source/schemas/common/types/actions.jsonplaced nominPropertieson the map (onlyminItems: 1on the array values), so an empty"actions": {}validated while violating that MUST.Fix
Add
minProperties: 1to the map. The map should be absent, not empty, when there is no outstanding work, and a schema-driven validator now catches the empty case.Verification
ucp-schema lint source/clean;validate_examples.py282 passed (unchanged). No example emits an empty actions map. Verified with a JSON Schema validator that{}is now rejected and a non-empty map still passes.Raised from #665.