fix: make Request-Signature header optional in shopping spec - #637
Open
sbeashwar wants to merge 1 commit into
Open
Conversation
Open
1 task
sbeashwar
marked this pull request as ready for review
July 29, 2026 22:17
damaz91
added
status:needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the
Request-Signatureheader parameter optional (required: false) in the shopping REST spec, in both thesource/and generatedspec/OpenAPI, and clarifies its description.Why
The shopping OpenAPI marks
Request-Signatureasrequired: trueon every operation, which contradicts this release's own Message Signatures spec (signatures.md, "When Signatures Apply"): platforms SHOULD sign requests, and MAY use alternative authentication (API keys, OAuth, mTLS) instead. As written, the OpenAPI forces a signature header even when a platform authenticates by another mechanism, and clients/validators generated from this spec reject otherwise-valid unsigned requests.mainalready treats request signing as optional (the header is not unconditionally required there). This backports that intent to the2026-01-23release with a minimal, backward-compatible change - it does not pull in main's larger RFC 9421 header restructure. Existing signed requests remain valid; the only effect is that unsigned requests using alternative auth are no longer rejected by the spec.Scope
source/services/shopping/openapi.jsonspec/services/shopping/rest.openapi.jsonNo behavioral change for signed requests; no schema fields added or removed. Consistent with prior backports to this release branch (e.g. #212, #228).
Addresses #636.