fix: use configured base price in fulfillment total assertion - #72
Merged
damaz91 merged 1 commit intoAug 3, 2026
Conversation
test_fulfillment_flow hardcoded 3500 as the item base price when computing expected_total, while every other test resolves it via fixture_ctx.get_test_price(). The hardcoded 3500 only matches the default flower_shop fixture (35.00 -> 3500); any fixture configured with a different item price would fail the total assertion even though the server behaved correctly. get_test_price() already returns minor units, so this is a pure substitution with no unit conversion.
damaz91
approved these changes
Aug 3, 2026
ptiper
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_fulfillment_flowinfulfillment_test.pyhardcoded3500as the item base price when computing the expected total:Every other test in the suite resolves the item price via
fixture_ctx.get_test_price(). The hardcoded3500only matches the default flower_shop fixture (valid_item.expected_price35.00 → 3500); a fixture configured with a different item price would fail the total assertion even though the server behaved correctly — the same class of "default-only" bug as the recently-fixed hardcoded discount amount.get_test_price()already returns minor units, so this is a pure substitution with no unit conversion.Type of change
Is this a Breaking Change or Removal?
N/A — test-only fix, no schema/field removal.
Checklist