test(integration): assert operator-permission denial (ERR_CHANOPRIVSN…#7
Merged
Conversation
…EEDED) Covers the sheet's scored operator section: a non-operator member is denied KICK / MODE / TOPIC(+t) / INVITE(+i) with 482, and — the other side — may still set TOPIC / INVITE when the channel isn't +t / +i. Pure coverage: the denials already worked (audit found no bug); these lock the behavior in. COVERAGE.md row E: red -> green. Suite 145/145.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds 6 characterization tests for channel-operator permission denial
(ERR_CHANOPRIVSNEEDED / 482): KICK, MODE(+t), TOPIC(+t), INVITE(+i) denied for
a non-op member; plus the other side — TOPIC/INVITE allowed when the channel
isn't +t/+i. Closes the sheet's scored operator section (0–5) coverage gap.
Why it's safe
Pure coverage — no production change (audit found the denials already correct).
Diff touches only tests/test_integration.cpp and tests/COVERAGE.md (row E 🔴→✅).
Verification
not 442-in-disguise; refactor(server): stop branching on errno after accept/recv/send #5 can't false-green even if the gate broke)