-
Notifications
You must be signed in to change notification settings - Fork 0
Add a move binary (mv replacement) reusing the copy engine
#11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,20 +34,16 @@ jobs: | |
| include: | ||
| - os: ubuntu-latest | ||
| target: x86_64-unknown-linux-gnu | ||
| artifact_name: copy | ||
| asset_name: copy-linux-x86_64 | ||
| platform: linux-x86_64 | ||
| - os: ubuntu-latest | ||
| target: x86_64-unknown-linux-musl | ||
| artifact_name: copy | ||
| asset_name: copy-linux-x86_64-musl | ||
| platform: linux-x86_64-musl | ||
| - os: ubuntu-latest | ||
| target: aarch64-unknown-linux-gnu | ||
| artifact_name: copy | ||
| asset_name: copy-linux-aarch64 | ||
| platform: linux-aarch64 | ||
| - os: ubuntu-latest | ||
| target: armv7-unknown-linux-gnueabihf | ||
| artifact_name: copy | ||
| asset_name: copy-linux-armv7 | ||
| platform: linux-armv7 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
@@ -68,26 +64,23 @@ jobs: | |
| sudo apt-get update -q | ||
| sudo apt-get install -y binutils-arm-linux-gnueabihf binutils-aarch64-linux-gnu | ||
|
|
||
| - name: Strip binary | ||
| - name: Strip and archive binaries | ||
| run: | | ||
| if [[ "${{ matrix.target }}" == *"musl"* ]]; then | ||
| strip target/${{ matrix.target }}/release/${{ matrix.artifact_name }} || true | ||
| elif [[ "${{ matrix.target }}" == "armv7-unknown-linux-gnueabihf" ]]; then | ||
| arm-linux-gnueabihf-strip target/${{ matrix.target }}/release/${{ matrix.artifact_name }} || true | ||
| elif [[ "${{ matrix.target }}" == "aarch64-unknown-linux-gnu" ]]; then | ||
| aarch64-linux-gnu-strip target/${{ matrix.target }}/release/${{ matrix.artifact_name }} || true | ||
| else | ||
| strip target/${{ matrix.target }}/release/${{ matrix.artifact_name }} | ||
| fi | ||
| case "${{ matrix.target }}" in | ||
| *musl*) strip_cmd=strip ;; | ||
| armv7-unknown-linux-gnueabihf) strip_cmd=arm-linux-gnueabihf-strip ;; | ||
| aarch64-unknown-linux-gnu) strip_cmd=aarch64-linux-gnu-strip ;; | ||
| *) strip_cmd=strip ;; | ||
| esac | ||
| rel="target/${{ matrix.target }}/release" | ||
| for bin in copy move; do | ||
| "$strip_cmd" "$rel/$bin" || true | ||
| tar czf "$bin-${{ matrix.platform }}.tar.gz" -C "$rel" "$bin" | ||
| done | ||
|
|
||
| - name: Create archive | ||
| run: | | ||
| cd target/${{ matrix.target }}/release | ||
| tar czf ${{ matrix.asset_name }}.tar.gz ${{ matrix.artifact_name }} | ||
| cd - | ||
| mv target/${{ matrix.target }}/release/${{ matrix.asset_name }}.tar.gz . | ||
|
|
||
| - name: Upload Release Asset | ||
| - name: Upload Release Assets | ||
| uses: softprops/action-gh-release@v3 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Read-only check: list workflow actions that are referenced by tag instead of SHA.
rg -n '^\s*uses:\s*[^@]+@v?[0-9][^ ]*$' .github/workflowsRepository: UnbreakableMJ/copy Length of output: 470 Pin Lines 24 and 82 use 🧰 Tools🪛 zizmor (1.26.1)[error] 82-82: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) [info] 82-82: action functionality is already included by the runner (superfluous-actions): use (superfluous-actions) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| with: | ||
| files: ./${{ matrix.asset_name }}.tar.gz | ||
| files: | | ||
| copy-${{ matrix.platform }}.tar.gz | ||
| move-${{ matrix.platform }}.tar.gz | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Artifact platform names no longer match installer expectations.
Line 37-46 publishes
linux-aarch64/linux-armv7, but installer downloads*-aarch64-musl/*-armv7-muslnames. That causes release download 404s on those architectures.Please align the naming contract between workflow artifacts and installer URLs (either side can be the source of truth).
🤖 Prompt for AI Agents