Fix/failed state screen - #233
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the app/package version and adjusts VPN teardown behavior so that, when the VPN tunnel closes after an error, the connection status can optionally remain in an error state (instead of being forced back to disconnecting/disconnected).
Changes:
- Bump app version to
5.8.0+287and Windows MSIX version to5.8.0.287. - Update
_closeTunnelto accept akeepConnectionStatusflag, preventing state transitions to disconnecting/disconnected when preserving an error state. - Pass
keepConnectionStatusfor"Data: VPN cancelled"/"Data: VPN stopped"events when the current connection status isConnectionStatus.error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pubspec.yaml | Version bump for the app and MSIX packaging. |
| lib/modules/core/vpn.dart | Preserve error connection status across tunnel-close paths for cancelled/stopped events. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Briefly describe what this PR does and why. Keep it short and clear.
Related Platforms
Verification Checklist
Optional (for bigger changes)
Related Links
Closes #ID.