Fix/get pattern - #231
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates how the app derives the “connection method pattern” from settings, bumps the app version metadata, and refreshes iOS CocoaPods lockfile dependencies.
Changes:
- Adjusted
getConnectionMethodPattern()to build the pattern from enabled items’ titles (instead of IDs). - Updated
pubspec.yamlapp version and MSIX packaging metadata. - Updated
ios/Podfile.lock, including changes to Firebase/FlutterFire pod versions.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pubspec.yaml | Version bump and MSIX package version update (currently inconsistent). |
| lib/modules/settings/providers/settings_provider.dart | Changes the source field used to build the connection method pattern string. |
| ios/Podfile.lock | Updates iOS pod resolution, including Firebase-related pods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
104
to
109
| msix_config: | ||
| display_name: Defyx VPN | ||
| publisher_display_name: UnboundTech UG | ||
| identity_name: UnboundTechUG.6065AEC5A207 | ||
| msix_version: 5.7.3.284 | ||
| msix_version: 5.7.4.285 | ||
| publisher: "CN=62937938-2AE2-4C12-9ED8-4C418C0CADF2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Briefly describe what this PR does and why. Keep it short and clear.
Related Platforms
Verification Checklist
Optional (for bigger changes)
Related Links
Closes #ID.