Fix/flowline toggle bug - #230
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to address a “flowline toggle” issue in the Settings UI by adjusting how flowline-derived settings items are identified, while also bumping the app version and updating iOS CocoaPods lockfile dependencies.
Changes:
- Bumped app version in
pubspec.yamlto5.7.3+284. - Modified flowline settings item ID generation to incorporate
sortOrder. - Updated iOS locked pod versions (Firebase / Google utilities related).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pubspec.yaml | App version bump for the release containing the fix. |
| lib/modules/settings/factories/settings_factory.dart | Changes flowline item ID generation (core of the toggle bug fix attempt). |
| ios/Podfile.lock | Updates locked iOS dependency versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
44
to
46
| return SettingsItem( | ||
| id: label, | ||
| id: label + sortOrder.toString(), | ||
| title: label, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Briefly describe what this PR does and why. Keep it short and clear.
Related Platforms
Verification Checklist
Optional (for bigger changes)
Related Links
Closes #ID.