Add rc default for text borderstyle - #549
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
cvanelteren
force-pushed
the
feat/text-borderstyle-rc
branch
from
February 3, 2026 21:33
ad32f11 to
307d896
Compare
beckermr
reviewed
Feb 3, 2026
| "Width of the white border around a-b-c labels.", | ||
| ), | ||
| "text.borderstyle": ( | ||
| "miter", |
Collaborator
There was a problem hiding this comment.
Shouldn't this default be bevel?
Collaborator
Author
There was a problem hiding this comment.
yes! it should hazzy brain
beckermr
requested changes
Feb 3, 2026
beckermr
left a comment
Collaborator
There was a problem hiding this comment.
See the comment above.
beckermr
approved these changes
Feb 4, 2026
K-Mirembe-Mercy
pushed a commit
to K-Mirembe-Mercy/UltraPlot
that referenced
this pull request
Mar 22, 2026
* Add rc default for text borderstyle * Set correct default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By defualt matplotlib uses miter for borderstyle on text, this makes the annotated text look jagged. It would look nicer if this was beveled. Proposal to move to beveled by default and add an rc parameter to config this.
Closes #548