Skip to content

Fix/revert debug and clean #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvanelteren merged 2 commits into from
Feb 1, 2026
Merged

Fix/revert debug and clean #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
888cbdc
Revert "Add debug logging for selected mpl tests"
cvanelteren Feb 1, 2026
9bc9d19
Fix leftover merge markers in test_config
cvanelteren Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/build-ultraplot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,6 @@ jobs:
if: steps.cache-baseline.outputs.cache-hit != 'true' || !env.IS_PR
run: |
mkdir -p ultraplot/tests/baseline
echo "TEST_MODE=${TEST_MODE}"
echo "IS_PR=${IS_PR}"
echo "PR_BASE_SHA=${{ github.event.pull_request.base.sha }}"
echo "TEST_NODEIDS=${TEST_NODEIDS}"
# Save PR-selected nodeids for reuse after checkout (if provided)
if [ "${TEST_MODE}" = "selected" ] && [ -n "${TEST_NODEIDS}" ]; then
printf "%s\n" ${TEST_NODEIDS} > /tmp/pr_selected_nodeids.txt
Expand Down Expand Up @@ -133,7 +129,6 @@ jobs:
echo "${filtered}"
}
FILTERED_NODEIDS="$(filter_nodeids)"
echo "FILTERED_NODEIDS_BASE=${FILTERED_NODEIDS}"
if [ -z "${FILTERED_NODEIDS}" ]; then
echo "No valid nodeids found on base; skipping baseline generation."
exit 0
Expand Down Expand Up @@ -168,8 +163,6 @@ jobs:

mkdir -p results
python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')"
echo "TEST_MODE=${TEST_MODE}"
echo "TEST_NODEIDS=${TEST_NODEIDS}"
if [ "${TEST_MODE}" = "selected" ] && [ -s /tmp/pr_selected_nodeids.txt ]; then
status=0
filter_nodeids() {
Expand All @@ -183,7 +176,6 @@ jobs:
echo "${filtered}"
}
FILTERED_NODEIDS="$(filter_nodeids)"
echo "FILTERED_NODEIDS_PR=${FILTERED_NODEIDS}"
if [ -z "${FILTERED_NODEIDS}" ]; then
echo "No valid nodeids found on PR branch; skipping image comparison."
exit 0
Expand Down
2 changes: 0 additions & 2 deletions ultraplot/tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,5 +213,3 @@ def _reader():
observed = [results.get() for _ in range(results.qsize())]
assert observed, "No rcParams observations were recorded."
assert all(value in allowed for value in observed)
=======
>>>>>>> 05e1ec4a (Add threaded rc cycle consistency test)
Loading