[EMB-545] Add ionizer gpio - #224
Open
Paul Kuiper (pkuiper-ultimaker) wants to merge 1 commit into
Open
Paul Kuiper (pkuiper-ultimaker) wants to merge 1 commit into
Paul Kuiper (pkuiper-ultimaker) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Paul Kuiper (pkuiper-ultimaker)
October 1, 2026 11:19
View session
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unrelated GPIO names are removed, breaking consumers that resolve those lines by name.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds an ionizer GPIO line name to the Ultimainboard 5 device tree.
Changes:
- Replaces GPIO offset 0 with
IONIZER_EN. - Clears several existing GPIO line names.
| File | Description |
|---|---|
dts/ultimainboard5-lvds.dtsi |
Updates TCA6416 GPIO line names. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+184
to
+187
| gpio-line-names = "IONIZER_EN", "", "", "", | ||
| "HDMI_PWR_EN", "HDMI_PWR_OK", "", "", | ||
| "", "", "LVDS_PWR_EN", "LVDS_PWR_OK", | ||
| "SAFETY_BTN_STATUS", "SAFETY_RESET", "", ""; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ionizer output signal.
See EMB-545