Fix ax25SendUFrame stack overflow on U-frame length write - #8
Open
SimonVutov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes UWOrbital/obc-firmware#437
Fixes the Mac-specific
uFrameSendRecv*test failures (UWOrbital/obc-firmware#437).Changes
ax25SendUFramepassed auint8_tstruct member as auint16_t*toax25Stuff, causing a 1-byte stack buffer overflow. This was tolerated on Linux but causedSIGABRTon macOS, aborting theobc-interface-testsbinary.The fix writes the stuffed length to a temporary
uint16_tbefore assigning it to theuint8_tlength field.Verified against
obc-firmware's test suite. Before the fix,TestAx25SendRecv.uFrameSendRecvConnaborted the test binary; afterwards, all threeuFrameSendRecv*tests pass.Testing
Before the fix (the test aborts on
uFrameSendRecvConn):After the fix (all three U-frame tests pass):