278 corps castle link not redirecting correctly#281
Merged
willbreitkreutz merged 4 commits intoMay 18, 2026
Conversation
… Remove any logic from breadcrumb items, just use the href provided.
…usace logo in the header, just pass that href down, or if not provided bail with a `#`
|
Please set a versioning label of either |
krowvin
requested changes
May 11, 2026
Contributor
krowvin
left a comment
krowvin
left a comment
There was a problem hiding this comment.
Seems we both took a crack at this!
I should have assigned I only set it as a child issue
Also good we both did because I did not go the route of adding the home link param. Agreed on that.
But consider the default. If you believe it should be # ?
krowvin
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a couple of the link issues. This should solve the breadcrumbs not working #273 and the corps castle link issue #278 .
Checklist
patch-bump,minor-bump, ormajor-bumpRelease impact
Should not have any breaking changes, but adds to the api of SiteWrapper