Fix time-series requests with explicit response units - #1902
Open
krowvin wants to merge 1 commit into
Open
Conversation
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Collaborator
Author
|
Job failure are due to power outage. HEC Nexus is down. |
MikeNeilson
reviewed
Aug 27, 2026
MikeNeilson
left a comment
Contributor
There was a problem hiding this comment.
Seems like a reasonable change.
krowvin
marked this pull request as ready for review
August 27, 2026 17:52
Collaborator
Author
|
I had drafted while I waited on the HEC box to come back. If you approve I'll go ahead and merge it in. Unless you're wanting to give it a minute for others to see? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AV_TSV_DQUdata view with native-to-response unit convertibility validationThe prior validation issued up to two existence queries against all historical rows for a time series without applying the requested begin/end range. For long-lived series, Oracle could spend the full CDA request timeout validating the unit before executing the bounded data query.
Related Issue
Closes #1901
Validation
:cwms-data-api:compileJava,compileTestJava,checkstyleMain, andcheckstyleTestTimeSeriesDirectReadParityIT.convertedUnitReadMatchesRetrieveTsagainst latest-dev OracleTimeseriesControllerTestIT.test_wrong_unitsagainst latest-dev Oraclegradlew build: 734 tests passed, 37 skipped; 9 unrelated Mockito tests failed because the local Java 21 runtime is newer than the repository's pinned Byte Buddy support (Java 19)The exact reported two-day payload did not time out against the latest-dev Oracle 23.5 test database. Database schema comparison found the relevant view definition unchanged across recent CWMS database releases; optimizer version, statistics, and historical row volume can explain why the deployed MVP database exhibits the timeout.
Checklist