Update various packages.#1676
Conversation
|
UI still works, also corrected the behavior for the swagger-docs link, previous fix did not quite do the trick. |
MikeNeilson
force-pushed
the
devops/package-updates
branch
from
4e7122b to
6a6657e
Compare
krowvin
left a comment
krowvin
left a comment
There was a problem hiding this comment.
Wondering about the version downgrade on the generator before you merge
| }, | ||
| "devDependencies": { | ||
| "@openapitools/openapi-generator-cli": "^2.15.3", | ||
| "@openapitools/openapi-generator-cli": "^0.0.6", |
There was a problem hiding this comment.
Why are we downgrading the generator? I think we might have picked the wrong version because this could introduce some unforeseen security issues going this far back?
I assumed it might be because of the old javalin/java version but wanted to make sure.
There was a problem hiding this comment.
Huh, thanks, didn't catch that. I'm not sure what happened there, I ran npm audit fix --force might have had something to do with the force, but definitely going backwards there.
MikeNeilson
force-pushed
the
devops/package-updates
branch
from
6a6657e to
426df70
Compare
| }, | ||
| { | ||
| id: "swagger-docs", | ||
| path: "swagger-docs", |
There was a problem hiding this comment.
@krowvin I had put some logging in here, and it just never gets called. Just goes right to the ErrorFallback.jsx page that's defined, and the error itself is undefined.
So far as I can tell this should be the correct way to specify this but it's not working. Perhaps the location replace defined in a handler for one of the "routeComponenents" but that seems odd. This was working before the recent inclusion of the route-paths.js and just... really isn't different so I'm a bit confused.
2 participants
Am manually testing the CDA GUI now, wanted to get the rest of the build started.
Manually handles several dependabot/security reports that weren't getting updated by the automation.