Skip to content

Fix FireRed showmonpic and battle frame types - #63

Open
Lokesh-shiva wants to merge 2 commits into
UNDERdecoded:mainfrom
Lokesh-shiva:firered-visual-backlog
Open

Lokesh-shiva wants to merge 2 commits into
UNDERdecoded:mainfrom
Lokesh-shiva:firered-visual-backlog

Conversation

@Lokesh-shiva

Copy link
Copy Markdown
Contributor

Summary

  • Fix FireRed showmonpic placement so script coordinates match the retail outer-frame origin.
  • Generate and use all 10 FireRed user-selected battle Frame Types for the action, move, and message panels.
  • Bump the ROM cache format to v339 so per-frame battle panel assets regenerate correctly.

Verification

  • Compared showmonpic behavior directly with pokefirered and verified the outer box is 10,3 (10x10 tiles) with the YES/NO box meeting it edge-to-edge without overlap.
  • Forced a fresh FireRed v339 import and verified 10 generated frameImages sets.
  • Live battle runtime checks passed for Frame Types 1, 2, and 10.
  • Independently verified Frame Type 1 vs 10 on both the command menu and move-selection screen.
  • Verified legacy-cache fallback with frameImages absent while gen3Frame=10.
  • git diff --check passes.

Scope

  • Only 4 production files are included in this PR.
  • tools/rom_manifest_firered.json is unchanged.
  • Screenshots, videos, generated cache data, and scratch validation drivers are not committed.
  • The historical player/NPC pixel-line report was not reproducible in the scenes rechecked here and is not claimed as fixed by this PR.

Note: the repository-wide Bash wrapper could not run on this Windows host because WSL has no installed distribution and no standalone Lua/LuaJIT is on PATH; the modified FireRed paths were instead exercised through focused real LOVE runtime/import validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants