Fix FireRed showmonpic and battle frame types - #63
Open
Lokesh-shiva wants to merge 2 commits into
Open
Lokesh-shiva wants to merge 2 commits into
Lokesh-shiva wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showmonpicplacement so script coordinates match the retail outer-frame origin.Verification
showmonpicbehavior directly withpokefireredand verified the outer box is10,3(10x10 tiles) with the YES/NO box meeting it edge-to-edge without overlap.frameImagessets.frameImagesabsent whilegen3Frame=10.git diff --checkpasses.Scope
tools/rom_manifest_firered.jsonis unchanged.Note: the repository-wide Bash wrapper could not run on this Windows host because WSL has no installed distribution and no standalone Lua/LuaJIT is on PATH; the modified FireRed paths were instead exercised through focused real LOVE runtime/import validation.