Add channel edge handling to PinholeSPECTUB - #1749
Open
TommasoFerri97 wants to merge 3 commits into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 36 |
| Duplication | 46 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have not yet signed the STIR Contribution License Agreement. Please let me know the required procedure.
Changes in this pull request
This pull request adds support for channel-edge pinhole collimators in PinholeSPECTUB, while preserving the existing knife-edge implementation.
The main changes are:
dycm) to the pinhole geometry definition.knifeor when the channel width is set to zero.Testing performed
The channel-edge implementation was tested with a PinholeSPECTUB reconstruction using a finite-width pinhole channel.
Checklist before requesting a review
Contribution Notes
Please tick the following: