Conversation
… within helix boundaries
Contributor
Author
|
I realize I had to cancel GitHub workflow since the test cases would have hanged |
Member
|
Sorry, re-reading this issue, I want different behavior than originally specified in the issue. Check the part after UPDATE: #368 |
…o-ensure-offsets-are-within-helix-boundaries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if test cases were necessary, but I added them. Though there are two problems with this:
04:24 +250: test/strand_mirror_unit_test.dart: StrandReflectValid strand_reflect_vertically_polarity_reverse WARNING: some Action changed the design, so I am writing the Design to localStorage, but that action is not UndoableAction, LoadDNAFile, Undo, or Redo action is StrandsReflect { strands=[Strand { substrands=[Domain { helix=0, forward=true, start=0, end=10, deletions=[], insertions=[], is_first=true, is_last=false, is_scaffold=false, strand_id=strand-H0-0-forward, unused_fields={}, }, Domain { helix=1, forward=false, start=5, end=10, deletions=[], insertions=[], is_first=false, is_last=true, is_scaffold=false, strand_id=strand-H0-0-forward, unused_fields={}, }], is_scaffold=false, circular=false, modifications_int={}, color=r: 247, g: 67, b: 8, unused_fields={}, }], horizontal=false, reverse_polarity=true, }The bug seems to be fixed, and running the test script passes all test cases, aside from having to spam "ok" and the warnings that appear.
I could not find a similar test case in which a window alert is involved, so I'm not sure how to go around this. And I'm quite lost on why the warnings appear.