possible fix for nested layouts

[troyciesco]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ae72115e-1be2-4f4d-ac4d-940ba12e24ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch suggestion/recursive-template

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lib/checks/130-template-inheritance.js`:
- Around line 25-27: The code returns absolute layout keys (leading '/') which
don't match theme-relative lookup keys; change the branch in the layout
normalization to normalize then strip any leading slashes so returned keys are
theme-relative. Specifically, update the logic around layout.startsWith('/') to
use path.posix.normalize(layout) and then remove leading '/' characters (e.g.,
via a replace(/^\/+/, '')) before returning so lookups using the layout variable
match the graph keys like "default.hbs".

In `@test/130-template-inheritance.test.js`:
- Around line 6-14: The tests currently use a custom runCheck(files) helper that
calls thisCheck directly; replace those inline file-object tests with the shared
fixture-based harness by creating theme fixtures under test/fixtures/themes/ and
invoking utils.testCheck(...) (using themePath(...) when referencing fixture
dirs) instead of runCheck/thisCheck; update each occurrence (runCheck,
thisCheck) in the listed blocks (and the test file's calls at lines ~6 and the
other ranges) to call utils.testCheck with the appropriate fixture path and
expected results so the tests follow the standard contract and fixture flow.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b9ccae43-0dea-4c63-8ef5-a7d82abff2de

📥 Commits

Reviewing files that changed from the base of the PR and between 4ea22b9 and a32a2e9.

📒 Files selected for processing (2)

• lib/checks/130-template-inheritance.js
• test/130-template-inheritance.test.js