Feature/boe fix on shred

[manishdex25]

Summary

What is the background of this pull request?

Changes

• What are the changes made in this pull request?
• Change this and that, etc...

Issues

What are the related issues or stories?

Summary by CodeRabbit

• Bug Fixes
  • Improved token mint status detection by aligning it with standard token registry behavior.
  • Tokens are now considered minted when owned by any non-zero address, including the burn address.
  • Removed additional escrow validation that could incorrectly reject valid minted tokens.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c05ec3a-a6aa-43c1-aa25-97de44a92cbc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

src/__tests__/verify/obligationRecordVerifier.utils.test.ts (1)

25-28: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Rename the test to match the registry-only assertion.

The test no longer verifies an active title or escrow state. It verifies that a non-zero ownerOf result is minted.

Proposed test-name update

-  it('returns minted when owner is set (active title)', async () => {
+  it('returns minted when owner is set (non-zero owner)', async () => {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/__tests__/verify/obligationRecordVerifier.utils.test.ts` around lines 25
- 28, Rename the test case around mockOwnerOf and the ownerOf assertion to
describe that a non-zero ownerOf result is minted, removing references to active
titles, escrow, or owner state.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/__tests__/verify/obligationRecordVerifier.utils.test.ts`:
- Around line 25-28: Rename the test case around mockOwnerOf and the ownerOf
assertion to describe that a non-zero ownerOf result is minted, removing
references to active titles, escrow, or owner state.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a266ca9b-7498-44df-9f9a-69f51f8d56b3

📥 Commits

Reviewing files that changed from the base of the PR and between 0f56031 and d4fad0b.

📒 Files selected for processing (2)

• src/__tests__/verify/obligationRecordVerifier.utils.test.ts
• src/verify/fragments/document-status/obligationRecords/utils.ts

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud