Skip to content
This repository was archived by the owner on Jun 22, 2026. It is now read-only.

added content_type to save file - #203

Merged
eldonm merged 2 commits into
mainfrom
2.1.25
Jan 19, 2026
Merged

added content_type to save file#203
eldonm merged 2 commits into
mainfrom
2.1.25

Conversation

@Tharickv75

Copy link
Copy Markdown
Contributor

Type of Change

  • 🐛 Bug Fix

Summary

Added proper handling of Content-Type in the save_file function so empty values no longer break S3 auto-detection.

Description

Bug Fixes

  • Previously, passing content_type="" sent an empty Content-Type to S3
  • Now only sends Content-Type when a real value is provided

Changes Made

  • Updated save_file to conditionally include ContentType parameter

Steps to Test

  1. Upload with content_type="" → Content-Type should be auto-detected
  2. Upload with specific type (e.g. image/png) → type should be set correctly
  3. Upload without content_type → auto-detection should work

@Tharickv75
Tharickv75 requested review from Gim3l and eldonm January 19, 2026 20:20
@Tharickv75 Tharickv75 self-assigned this Jan 19, 2026
@github-actions

github-actions Bot commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
649 583 90% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
_init_.py 100% 🟢
TOTAL 100% 🟢

updated for commit: be433a8 by action🐍

@eldonm
eldonm merged commit a9dade2 into main Jan 19, 2026
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants