Monorepo: move the mobile app in, adopt npm workspaces, add packages/core

.claude/settings.json

@@ -1,5 +1,6 @@
 {
   "enabledPlugins": {
-    "frontend-design@claude-plugins-official": true
+    "frontend-design@claude-plugins-official": true,
+    "expo@claude-plugins-official": true
   }
 }

.github/workflows/core.yml

@@ -0,0 +1,78 @@
+name: Core
+
+# packages/core (@truetunes/core): typecheck, lint (including the platform-neutral import ban) and Node tests.
+on:
+  push:
+    branches: [main]
+    paths:
+      - 'packages/core/**'
+      - 'apps/mobile/src/types/globals.d.ts'
+      - 'package.json'
+      - 'package-lock.json'
+      - '.github/workflows/core.yml'
+  pull_request:
+    branches: [main, develop]
+    paths:
+      - 'packages/core/**'
+      - 'apps/mobile/src/types/globals.d.ts'
+      - 'package.json'
+      - 'package-lock.json'
+      - '.github/workflows/core.yml'
+
+permissions:
+  contents: read
+  checks: write
+  pull-requests: write
+
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+
+defaults:
+  run:
+    working-directory: packages/core
+
+jobs:
+  validate:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: '.nvmrc'
+          cache: 'npm'
+
+      - run: npm ci
+        working-directory: .
+
+      - run: npm run lint
+
+      - run: npm run typecheck
+
+      - name: Test with coverage
+        run: >
+          npm run test:run --
+          --reporter=default
+          --reporter=junit
+          --outputFile.junit=./junit.xml
+          --coverage
+
+      - name: Publish test results
+        uses: dorny/test-reporter@v1
+        if: always()
+        with:
+          name: Core Vitest Tests
+          path: packages/core/junit.xml
+          reporter: java-junit
+          fail-on-error: true
+
+      - name: Publish coverage report
+        uses: davelosert/vitest-coverage-report-action@v2
+        if: always()
+        with:
+          name: Core
+          json-summary-path: packages/core/coverage/coverage-summary.json
+          json-final-path: packages/core/coverage/coverage-final.json
+          vite-config-path: packages/core/vitest.config.ts

.github/workflows/publish.yml → .github/workflows/desktop.yml

@@ -1,10 +1,26 @@
-name: Publish
+name: Desktop
 
+# Validates desktop PRs; on push to main, bumps the patch version and publishes a desktop release.
+# Only desktop paths trigger it: without the filter, every mobile commit to main would publish a desktop release.
+# PRs also run it for server/ changes, because the server is linted with the desktop ESLint config.
 on:
+  # Publishing is narrower than validation: the root lock and packages/ change with mobile work too, and each
+  # push here ships a release. Desktop dependency changes always touch apps/desktop/package.json. Add packages/**
+  # once the desktop imports @truetunes/core.
   push:
     branches: [main]
+    paths:
+      - 'apps/desktop/**'
+      - '.github/workflows/desktop.yml'
   pull_request:
     branches: [main, develop]
+    paths:
+      - 'apps/desktop/**'
+      - 'packages/**'
+      - 'server/**'
+      - 'package.json'
+      - 'package-lock.json'
+      - '.github/workflows/desktop.yml'
 
 permissions:
   contents: write
@@ -14,6 +30,10 @@ permissions:
 env:
   FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
 
+defaults:
+  run:
+    working-directory: apps/desktop
+
 jobs:
   validate:
     runs-on: ubuntu-latest
@@ -27,9 +47,13 @@ jobs:
           cache: 'npm'
 
       - run: npm ci
+        working-directory: .
 
       - run: npm run lint
 
+      - run: npm run lint:server
+        working-directory: .
+
       - run: npm run typecheck
 
       - name: Test with coverage
@@ -45,17 +69,18 @@ jobs:
         if: always()
         with:
           name: Vitest Tests
-          path: renderer/junit.xml
+          path: apps/desktop/renderer/junit.xml
           reporter: java-junit
           fail-on-error: true
 
       - name: Publish coverage report
         uses: davelosert/vitest-coverage-report-action@v2
         if: always()
         with:
-          json-summary-path: renderer/coverage/coverage-summary.json
-          json-final-path: renderer/coverage/coverage-final.json
-          vite-config-path: renderer/vitest.config.ts
+          name: Desktop
+          json-summary-path: apps/desktop/renderer/coverage/coverage-summary.json
+          json-final-path: apps/desktop/renderer/coverage/coverage-final.json
+          vite-config-path: apps/desktop/renderer/vitest.config.ts
 
   version:
     needs: validate
@@ -72,18 +97,21 @@ jobs:
         with:
           node-version-file: '.nvmrc'
 
+      # --package-lock-only: bump apps/desktop/package.json and its entry in the root lock without installing anything.
       - name: Bump patch version
         id: bump
+        working-directory: .
         run: |
-          npm version patch --no-git-tag-version
-          echo "new_version=$(node -p "require('./package.json').version")" >> $GITHUB_OUTPUT
+          npm version patch -w apps/desktop --no-git-tag-version --package-lock-only
+          echo "new_version=$(node -p "require('./apps/desktop/package.json').version")" >> $GITHUB_OUTPUT
 
       - name: Commit and push
         id: push
+        working-directory: .
         run: |
           git config user.name "github-actions[bot]"
           git config user.email "github-actions[bot]@users.noreply.github.com"
-          git add package.json package-lock.json
+          git add apps/desktop/package.json package-lock.json
           git commit -m "chore: bump version to ${{ steps.bump.outputs.new_version }}"
           git push
           echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
@@ -112,7 +140,9 @@ jobs:
           cache: 'npm'
 
       - run: npm ci
+        working-directory: .
 
+      # electron-builder runs from apps/desktop (output in apps/desktop/release) and finds the hoisted node_modules itself.
       - run: npm run ${{ matrix.script }}
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/mobile-ci.yml

@@ -0,0 +1,82 @@
+name: Mobile CI
+
+on:
+  push:
+    branches: [main]
+    paths:
+      - 'apps/mobile/**'
+      - 'packages/**'
+      - 'package.json'
+      - 'package-lock.json'
+      - '.github/workflows/mobile-ci.yml'
+  pull_request:
+    branches: [main, develop]
+    paths:
+      - 'apps/mobile/**'
+      - 'packages/**'
+      - 'package.json'
+      - 'package-lock.json'
+      - '.github/workflows/mobile-ci.yml'
+
+permissions:
+  contents: read
+  checks: write
+  pull-requests: write
+
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
+  # The root npm ci installs the desktop workspace too; mobile never needs the Electron binary.
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+
+defaults:
+  run:
+    working-directory: apps/mobile
+
+jobs:
+  validate:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: '.nvmrc'
+          cache: 'npm'
+          cache-dependency-path: package-lock.json
+
+      - run: npm ci
+        working-directory: .
+
+      - run: npm run lint
+
+      - run: npm run typecheck
+
+      # Catches Expo SDK / native dependency mismatches before they become a broken build.
+      - run: npx expo-doctor
+
+      - name: Test with coverage
+        run: >
+          npm run test:run --
+          --reporter=default
+          --reporter=junit
+          --outputFile.junit=./junit.xml
+          --coverage
+
+      - name: Publish test results
+        uses: dorny/test-reporter@v1
+        if: always()
+        with:
+          name: Mobile Vitest Tests
+          path: apps/mobile/junit.xml
+          reporter: java-junit
+          fail-on-error: true
+
+      - name: Publish coverage report
+        uses: davelosert/vitest-coverage-report-action@v2
+        if: always()
+        with:
+          name: Mobile
+          json-summary-path: apps/mobile/coverage/coverage-summary.json
+          json-final-path: apps/mobile/coverage/coverage-final.json
+          vite-config-path: apps/mobile/vitest.config.ts