Repository navigation
Ship the Windows media controls addon in the installer - #106
Merged
Merged
Conversation
The 1.0.46 installer shipped without smtc.node: nothing compiled it in CI and build.files excluded native/, so the require failed silently and SMTC was a no-op. Add a build:native step to the Windows build/publish scripts and ship the addon via files + asarUnpack. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JTQFG7usNZcdYDTqmHr4QR
Contributor
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.0.46 announced Windows media controls, but the installer forgot to bring them.
smtc.nodewas never compiled in CI andbuild.filesexcludednative/, so the addon failed to load and SMTC silently did nothing.build:nativescript (node-gyp rebuild --directory native/smtc), run byelectron:build:winandelectron:publish:winsmtc.nodeadded tobuild.filesandasarUnpackVerified locally:
electron-builder --win --dirputs the addon atresources/app.asar.unpacked/native/smtc/build/Release/smtc.node, and the packaged Electron loads it via the asar path.🤖 Generated with Claude Code
https://claude.ai/code/session_01JTQFG7usNZcdYDTqmHr4QR