[codex] Refactor output plans and cleanup logic - #417
Merged
Merged
Conversation
- Introduced workspace scope handling in base_output_plans to manage cleanup files. - Updated cleanup logic to exclude workspace scope files from deletion. - Enhanced path normalization across output plans to ensure consistent path formatting. - Refactored regex compilation in project_prompt and skill modules for efficiency. - Improved error handling and logging in clean, dry_run, and install services. - Simplified output file building logic in output_plan service. - Added tests to validate new cleanup behavior and path normalization.
# Conflicts: # .github/workflows/ci.yml # doc/app/docs/[[...mdxPath]]/layout.tsx # sdk/src/domain/output_plans/mod.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The output plans duplicated path and home-directory handling, which made cleanup behavior inconsistent and caused path-sensitive tests to fail on Windows. Packaging coverage also lived in targets that no longer matched the current crate layout.
Impact
Output generation now uses shared behavior while retaining the existing target-specific files. CI packaging checks use the current CLI and MCP assembly flow.
Validation