Skip to content

chore: override glob, xml2js and katex past security advisories - #247

Merged
yordis merged 1 commit into
mainfrom
yordis/chore-security-transitive-overrides
Nov 21, 2026
Merged

yordis merged 1 commit into
mainfrom
yordis/chore-security-transitive-overrides

Conversation

@yordis

@yordis yordis commented Nov 21, 2026

Copy link
Copy Markdown
Member

Dependabot still had three open alerts on the root lockfile, all from packages we only get through other dependencies. This adds one override for each in pnpm-workspace.yaml.

  • glob@>=9 <14.0.2 to 14.0.6, for an abort signal bypass (fixed in 14.0.2). It comes from @electron/asar, @expo/cli and @expo/fingerprint. @electron/asar 4.3.2 already moved to glob 14 itself, and the expo packages only call glob/globSync without leading-slash ignore patterns, which is where 14 changed behavior. An asar round trip, the desktop artifact tests and fingerprint:generate for the mobile app all work.
  • dbus-next>xml2js to 0.6.2, for prototype pollution (fixed in 0.5.0). dbus-next only calls parseString on introspection XML. The desktop Linux D-Bus tests pass.
  • katex@<0.18.2 to 0.18.10, for a trust bypass (fixed in 0.18.2). The web app already renders math with 0.18. This moves the copies used by micromark-extension-llm-math and the mobile markdown web renderer onto the same version. The math and chat markdown tests pass.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:M 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The workspace configuration adds three dependency overrides. They set versions for selected glob, dbus-next/xml2js, and katex dependencies.

Changes: Dependency Overrides

Layer / File(s) Summary
Add dependency version overrides
pnpm-workspace.yaml
Adds overrides that resolve matching glob versions to 14.0.6, dbus-next’s xml2js dependency to 0.6.2, and matching katex versions to 0.18.10.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: juliusmarminge, yash-singh1

Merge Risk: Minimal · up to 5fe1b

This updates transitive dependency versions to address reported security alerts. The author reports that relevant tests pass, and no concrete merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: adding dependency overrides for glob, xml2js and katex to address security advisories. The raw summary, objectives and description all describe this change. The title is sp…
Description check Passed The description covers the problem (three open Dependabot alerts on the root lockfile), the change (one override per package in pnpm-workspace.yaml), and verification (asar round trip, desktop artifac…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: adding dependency overrides for glob, xml2js and katex to address security advisories. The raw summary, objectives and description all describe this change. The title is specific and concise, and it uses the conventional commit prefix.

Full details: Description check

Explanation

The description covers the problem (three open Dependabot alerts on the root lockfile), the change (one override per package in pnpm-workspace.yaml), and verification (asar round trip, desktop artifact tests, fingerprint:generate, desktop Linux D-Bus tests, math and chat markdown tests). It does not include a Scope section that links an issue or states why no issue is needed, and it does not include the model and harness line. Its headings also do not follow the template: it has no Problem, Change, Scope or Verification headings. The content is mostly complete, so the check passes, but the author should add the missing Scope information and use the template headings.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 0ff127c and 5fe1b88.

Files ignored due to path filters: 1

  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 1

  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@yordis
yordis merged commit 916bb23 into main Nov 21, 2026
31 of 32 checks passed
@yordis
yordis deleted the yordis/chore-security-transitive-overrides branch November 21, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:M vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant