Skip to content

chore: sync with upstream pingdotgg/t3code main - #244

Merged
yordis merged 689 commits into
mainfrom
yordis/chore-sync-upstream-20261121-1
Nov 21, 2026
Merged

yordis merged 689 commits into
mainfrom
yordis/chore-sync-upstream-20261121-1

Conversation

@yordis

@yordis yordis commented Nov 21, 2026

Copy link
Copy Markdown
Member
  • Kept the fork's standing instructions on pull request watches (0034) alongside upstream's new until and checksPending. Both survive syncs, re-watches, and ended watches, and a wake is refused if the instructions changed mid-read.
  • Kept the fork's wide table view (0038) and added upstream's Copy as HTML to its shared copy menu. Upstream's table find test now puts its match in the second column, because the fork pins a scrolled table's first column.
  • Took upstream's ClaudeDriver and dropped the fork's disabled-provider gate. Upstream's managed provider already skips enrichment for disabled snapshots.
  • Kept the orchestrator dispatch metrics and adapted them to upstream's new cascade and steer requeue call shapes. Added ledger entry 0039, since they had none.
  • Kept the narrower per-session cancellation of unsettled effects next to upstream's new firstSteer outbox field. Added ledger entry 0040.
  • Kept the fork's RPC trace test (0035). Upstream still roots each RPC in its own trace.
  • Kept the fork-only dev:desktop Electron profile line in the development docs. It is dev tooling, so it has no ledger entry.
  • Raised the MCP tool list context budget to its measured size, because the watch tool now describes both instructions and until.
  • Upstream's new pull request watch tests mock the pull request service without invalidate, which the fork's reactor calls on every sweep. Added it to those mocks.
  • Upstream now fails an empty commit with a typed GitNothingToCommitError before git runs. The fork's test now asserts that error instead of git's wording.
  • Removed a stray status line from the ledger index.
  • The infra/task-cache cleanup test fails the same way on main, so it is not caused by this sync.

juliusmarminge and others added 30 commits November 20, 2026 06:25
pingdotgg#39736)

Co-authored-by: PixPMusic <PixPMusic@users.noreply.github.com>
…gg#39733)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…t off (pingdotgg#39755)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gg#39817)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…39833)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#39855)

Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge and others added 23 commits November 21, 2026 08:12
…pingdotgg#40381)

Co-authored-by: Abaan <abaan@Abaans-MacBook-Pro.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… update fails (pingdotgg#37225)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…loopback (pingdotgg#40423)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…breaks (pingdotgg#40437)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…eck out (pingdotgg#40436)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…point in a shared folder (pingdotgg#40411)

Co-authored-by: ExSidius <17144735+ExSidius@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ironment probe (pingdotgg#37154)

Co-authored-by: lowlyleon <183293296+lowlyleon@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#37314)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…folder labels (pingdotgg#40464)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…n character set (pingdotgg#40476)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…0488)

Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pstream-20261121-1

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

# Conflicts:
#	apps/server/src/mcp/toolkits/pullRequests/handlers.ts
#	apps/server/src/mcp/toolkits/pullRequests/tools.ts
#	apps/server/src/observability/RpcInstrumentation.test.ts
#	apps/server/src/orchestration-v2/EffectOutbox.ts
#	apps/server/src/orchestration-v2/Orchestrator.ts
#	apps/server/src/orchestration-v2/PullRequestWatchReactor.ts
#	apps/server/src/orchestration-v2/pullRequestWatch.ts
#	apps/server/src/provider/Drivers/ClaudeDriver.ts
#	apps/server/src/provider/agentContextBudget.json
#	apps/server/src/pullRequest/PullRequestWatchService.ts
#	apps/web/src/components/chat/MarkdownTable.tsx
#	apps/web/src/i18n/translations/de.json
#	apps/web/src/i18n/translations/en.json
#	apps/web/src/i18n/translations/es.json
#	apps/web/src/i18n/translations/fr.json
#	apps/web/src/i18n/translations/ja.json
#	apps/web/src/i18n/translations/ko.json
#	apps/web/src/i18n/translations/pt-BR.json
#	apps/web/src/i18n/translations/ru.json
#	apps/web/src/i18n/translations/sv.json
#	apps/web/src/i18n/translations/zh.json
#	docs/operations/development.md
#	docs/user/source-control.md
#	package.json
#	packages/contracts/src/orchestrationV2.ts
#	pnpm-lock.yaml
…table behavior

Upstream's new pull request watch tests mock a pull request service without
invalidate, which the fork's reactor calls on every sweep. Upstream now fails
an empty commit with a typed error before git runs, so the fork's test checks
that error instead of git's wording. The fork pins a scrolled table's first
column, so the table find test puts its match in the second column.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XXL labels Nov 21, 2026
@github-actions

Copy link
Copy Markdown

This PR changes the test suite by +1903 test cases (browser +76, unit +1431, server +396).

New browser test files: apps/web/src/components/ProjectScriptsControl.browser.test.tsx, apps/web/src/components/PullRequestThreadDialog.browser.test.tsx, apps/web/src/components/chat/VoiceInputSetup.browser.test.tsx, apps/web/src/components/chat/preparingComposerImages.browser.test.tsx, apps/web/src/components/issue/IssueLinkPreview.browser.test.tsx, apps/web/src/components/settings/SnoozePresetsSettings.browser.test.tsx, apps/web/src/components/ui/search-input.browser.test.tsx.
Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.

Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing.

@github-actions github-actions Bot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Nov 21, 2026
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.5 KiB 21.5 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Other scenarios

4 of 64 scenario measurements changed or failed.

Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex fleet shell snapshot HTTP decoded 42.4 KiB 42.4 KiB +20 B (+0.0%) 53.7 KiB ✅
Codex stale shell reload HTTP decoded 42.4 KiB 42.4 KiB +20 B (+0.0%) 53.7 KiB ✅
Claude fleet shell snapshot HTTP decoded 43.0 KiB 43.0 KiB +20 B (+0.0%) 53.7 KiB ✅
Claude stale shell reload HTTP decoded 43.0 KiB 43.0 KiB +20 B (+0.0%) 53.7 KiB ✅
All 64 scenario measurements
Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex short turn resume WebSocket decoded 10.5 KiB 10.5 KiB 0 B (0.0%) 12.7 KiB ✅
Codex short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn running, cold open HTTP decoded 281.7 KiB 281.7 KiB 0 B (0.0%) 302.7 KiB ✅
Codex long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Codex long turn running, history page HTTP decoded 92.4 KiB 92.4 KiB 0 B (0.0%) 107.4 KiB ✅
Codex long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Codex long turn finished, cold open HTTP decoded 381.5 KiB 381.5 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, socket cold open WebSocket decoded 381.6 KiB 381.6 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, work page HTTP decoded 186.2 KiB 186.2 KiB 0 B (0.0%) 200.2 KiB ✅
Codex long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Codex idle thread resume WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell snapshot HTTP decoded 42.4 KiB 42.4 KiB +20 B (+0.0%) 53.7 KiB ✅
Codex fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Codex fleet shell subscribe WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Codex fleet shell resume check rows 0 0 0 0 ✅
Codex stale shell reload HTTP decoded 42.4 KiB 42.4 KiB +20 B (+0.0%) 53.7 KiB ✅
Codex stale shell reload rows 27 27 0 (0.0%) 27 ✅
Codex stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Codex stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex stale todo list cold open HTTP decoded 72.4 KiB 72.4 KiB 0 B (0.0%) 83.0 KiB ✅
Codex stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Codex stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅
Claude short turn resume WebSocket decoded 10.6 KiB 10.6 KiB 0 B (0.0%) 12.7 KiB ✅
Claude short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn running, cold open HTTP decoded 283.3 KiB 283.3 KiB 0 B (0.0%) 302.7 KiB ✅
Claude long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Claude long turn running, history page HTTP decoded 93.4 KiB 93.4 KiB 0 B (0.0%) 107.4 KiB ✅
Claude long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Claude long turn finished, cold open HTTP decoded 384.2 KiB 384.2 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, socket cold open WebSocket decoded 384.3 KiB 384.3 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, work page HTTP decoded 188.1 KiB 188.1 KiB 0 B (0.0%) 200.2 KiB ✅
Claude long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Claude idle thread resume WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell snapshot HTTP decoded 43.0 KiB 43.0 KiB +20 B (+0.0%) 53.7 KiB ✅
Claude fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Claude fleet shell subscribe WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Claude fleet shell resume check rows 0 0 0 0 ✅
Claude stale shell reload HTTP decoded 43.0 KiB 43.0 KiB +20 B (+0.0%) 53.7 KiB ✅
Claude stale shell reload rows 27 27 0 (0.0%) 27 ✅
Claude stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Claude stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude stale todo list cold open HTTP decoded 73.4 KiB 73.4 KiB 0 B (0.0%) 83.0 KiB ✅
Claude stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Claude stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅

Baseline: 995d805 · PR result: 88eecc7 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yordis
yordis merged commit b095301 into main Nov 21, 2026
48 of 51 checks passed
@yordis
yordis deleted the yordis/chore-sync-upstream-20261121-1 branch November 21, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:XXL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.