Skip to content

feat(monitoring): make node lifecycle stalls observable#444

Merged
yordis merged 1 commit into
masterfrom
yordis/feat-hosted-service-lifecycle-timing
Jul 19, 2026
Merged

feat(monitoring): make node lifecycle stalls observable#444
yordis merged 1 commit into
masterfrom
yordis/feat-hosted-service-lifecycle-timing

Conversation

@yordis

@yordis yordis commented Jul 19, 2026

Copy link
Copy Markdown
Member
  • Startup and shutdown stalls need a visible lifecycle boundary for production diagnosis.
  • Completion and failure timing must remain available without adding a general hosted-service framework for a single node service.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Jul 19, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Observability-only wrapping of existing start/stop behavior; failures still propagate and WhatIf is unchanged.

Overview
ClusterVNodeHostedService now logs clear start/stop lifecycle boundaries and elapsed time for cluster node startup and shutdown, so slow or stuck lifecycles show up in production logs without a broader hosted-service framework.

StartAsync and StopAsync are expanded from thin delegates into async methods that log “starting/stopping”, record duration via TimeProvider.System, log success with {Elapsed}, and on failure log the exception with elapsed time before rethrowing. WhatIf still skips startup entirely.

Reviewed by Cursor Bugbot for commit 6172ae3. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yordis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 87cd408d-6c4e-4515-9bcf-93fa8cc715e0

📥 Commits

Reviewing files that changed from the base of the PR and between c002bc9 and 6172ae3.

📒 Files selected for processing (1)
  • src/EventStore.ClusterNode/ClusterVNodeHostedService.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/feat-hosted-service-lifecycle-timing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis merged commit d9af4ae into master Jul 19, 2026
22 checks passed
@yordis
yordis deleted the yordis/feat-hosted-service-lifecycle-timing branch July 19, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant