Skip to content

fix(runtime): reject unsupported process architecture#441

Merged
yordis merged 2 commits into
masterfrom
yordis/fix-reject-32bit-process
Jul 17, 2026
Merged

fix(runtime): reject unsupported process architecture#441
yordis merged 2 commits into
masterfrom
yordis/fix-reject-32bit-process

Conversation

@yordis

@yordis yordis commented Jul 17, 2026

Copy link
Copy Markdown
Member
  • Prevents unsupported process architectures from running storage and replication code that relies on 64-bit runtime guarantees.
  • Fails before node initialization so operators receive a deterministic startup result.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Adds an early startup guard and a small test rename; no changes to storage, replication, or auth paths.

Overview
The cluster node now fails fast at startup if it is not running as a 64-bit process, logging a fatal message and exiting with code 1 before configuration, logging setup, or vnode initialization.

Test coverage is aligned with that guarantee: VerifyIntPtrSize (asserting IntPtr.Size == 8) is removed and replaced by ProcessArchitectureTests, which asserts Environment.Is64BitProcess under the test suite’s expected runtime.

Reviewed by Cursor Bugbot for commit d0b50c9. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yordis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bfa5a474-874c-41e4-aee2-3280f2349762

📥 Commits

Reviewing files that changed from the base of the PR and between 6079ffd and d0b50c9.

📒 Files selected for processing (3)
  • src/EventStore.ClusterNode/Program.cs
  • src/EventStore.Core.Tests/ProcessArchitectureTests.cs
  • src/EventStore.Core.Tests/VerifyIntPtrSize.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/fix-reject-32bit-process

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis merged commit e55aeec into master Jul 17, 2026
21 checks passed
@yordis
yordis deleted the yordis/fix-reject-32bit-process branch July 17, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant