fix(analysis): rank the date culture whose separator the values use, and flag disagreeing readings - #59
Merged
Conversation
…at culture first, and the facts say when date readings disagree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58.
Both proposals from the issue, a tie-break and an ambiguity flag:
CultureParseCounts.DatesWithOwnSeparator. So11.01.2018now goes to de-DE (11 January).11/01/2018keeps its previous order, because the invariant culture and en-US share the slash. ISO dates match no culture's separator and read the same under all of them, so their order is unchanged too.MinDateandMaxDatecome from the culture chosen by the same rule: numbers first, then dates, then dates written with the culture's own separator.ColumnFacts.DateReadingsDisagreeistruewhen the cultures that read the most values as dates read some row as different dates. It is measured, not inferred. Each culture keeps an order-free sum over the rows of a hash of (row, date), so one row read otherwise sets two cultures apart, including symmetric cases such as01.02and02.01.Performance: analysis timings on the corpus are within −1.7 % to +0.8 % of
main(median of 3 alternating runs).Tests:
AmbiguousDateTests, eight cases.