Theorem chat: spec-review completion pass - #198
Conversation
Stream ACP agent_message_chunk text into the Studio chat panel, hide Open Chat when ACP URL is unset, and align SPEC/healthcheck docs with the shipped cutover.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
|
Warning Review limit reached
Next review available in: 20 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR completes a spec-review “completion pass” for the Theorem Chat register cutover, focusing on (1) ACP streaming deltas reaching the chat UI, (2) hiding the Studio “Open Chat” command unless ACP is explicitly configured, and (3) tightening plan/spec/report documentation around the residual workspace healthcheck.
Changes:
- Forward
agent_message_chunktext into the ChatTransportonDeltacallback (end-to-end: theorem-acp helper + theorem-vscode adapter + tests). - Hide
theorem.openChatfrom the VS Code command palette unlessTHEOREM_ACP_WS_URL/theorem.agentUrlis set (plus runtime guard + tests). - Update SPEC/PLAN/EXECUTE-REPORT and clarify workspace Docker HEALTHCHECK residual.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packaging/workspace/Dockerfile | Clarifies that container HEALTHCHECK still targets OpenWork :8787 as a known residual (not product /chat). |
| packages/theorem-acp/src/state.ts | Exposes agentMessageTextFromUpdate helper for extracting assistant chunk text from ACP updates. |
| packages/theorem-acp/src/state.test.ts | Adds unit coverage for agentMessageTextFromUpdate. |
| docs/plans/theorem-chat-register/SPEC-THEOREM-CHAT-REGISTER-1.0.md | Updates ChatTransport contract to prompt(sessionId, text, onDelta) and documents delta semantics + rollback details. |
| docs/plans/theorem-chat-register/PLAN.md | Marks CR-006 as done. |
| docs/plans/theorem-chat-register/EXECUTE-REPORT.md | Updates the execute report to reflect Passes A–D and the residual healthcheck note. |
| apps/theorem-vscode/test/acp-chat.test.ts | Adds tests for chunk forwarding and acpConfigured behavior. |
| apps/theorem-vscode/src/extension.ts | Sets theorem.acpConfigured context and guards theorem.openChat when ACP isn’t configured. |
| apps/theorem-vscode/src/config.ts | Adds acpConfigured derivation and separates “explicit” agent URL from console origin. |
| apps/theorem-vscode/src/agent/session-opener.ts | Extends ACP session prompt to optionally subscribe to session updates and forward chunks during the prompt. |
| apps/theorem-vscode/src/agent/presence.ts | Updates AcpSession.prompt signature to accept optional onDelta. |
| apps/theorem-vscode/src/agent/chat-panel.ts | Removes stub delta and passes onDelta through to ACP prompt. |
| apps/theorem-vscode/src/agent/acp-chunks.ts | Introduces a small filter/adapter to forward only active-session agent_message_chunk updates. |
| apps/theorem-vscode/package.json | Hides theorem.openChat in the command palette unless theorem.acpConfigured is true. |
| .harness/checklists/theorem-chat-register--plan-local-20260805a.json | Updates checklist evidence note to reflect Pass B/C behavior and remaining optional smoke. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
prompt(..., onDelta)forwardsagent_message_chunktext (no more stub delta).theorem.openChathidden unlessTHEOREM_ACP_WS_URL/theorem.agentUrl(acpConfigured)./chatstill 307 login (no OpenWork proxy); workspace has ACP URL set so Open Chat stays visible after deploy. Signed-in panel/HTML stamp remains optional human smoke.Test plan
pnpm --filter @commonplace/theorem-acp test(20)pnpm --filter theorem-vscode test(64) + buildpnpm --filter @commonplace/theorem-chat-register test/IDEone-turn +/chatstamp screenshot