Skip to content

Fix Studio patch 0003 TS build break (Copilot retirement) - #191

Merged
Travis-Gilbert merged 1 commit into
mainfrom
fix/studio-patch-0003-ts
Aug 5, 2026
Merged

Fix Studio patch 0003 TS build break (Copilot retirement)#191
Travis-Gilbert merged 1 commit into
mainfrom
fix/studio-patch-0003-ts

Conversation

@Travis-Gilbert

Copy link
Copy Markdown
Owner

Summary

  • First 644d1ba8 Studio build failed: chatStatusEntry TS2345 (string | undefined into affectsConfiguration) and unused assertDefined after removing the onboarding assert (TS6133).
  • Regenerated 0003-retire-default-chat-agent-copilot.patch against clean 1.131.0 with those two fixes; ledger-gate + git apply --check green locally.

Test plan

  • git apply --check all three patches on 1.131.0
  • packaging/commonplace-studio/scripts/ledger-gate.sh
  • Railway commonplace-workspace SUCCESS for this commit
  • Live: no defaultChatAgent; no extensions/copilot; /workspace/repo has HEAD

Unblocks CR-001/CR-002 of plan-theorem-chat-register-20260805a.

Narrow chatStatusEntry affectsConfiguration and drop the unused
assertDefined import that failed the first Railway reh-web compile.
Copilot AI lite review requested due to automatic review settings August 5, 2026 21:29
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Travis-Gilbert, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f62a7813-69fb-4323-a369-3992f36442ae

📥 Commits

Reviewing files that changed from the base of the PR and between 33a13ee and 3cb8c0e.

📒 Files selected for processing (4)
  • .harness/checklists/theorem-chat-register--plan-local-20260805a.json
  • docs/plans/theorem-chat-register/EXECUTE-REPORT-CR001-CR002.md
  • packaging/commonplace-studio/LEDGER.md
  • packaging/commonplace-studio/patches/0003-retire-default-chat-agent-copilot.patch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ecc-tools

ecc-tools Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@Travis-Gilbert
Travis-Gilbert merged commit 9363e54 into main Aug 5, 2026
5 checks passed
@Travis-Gilbert
Travis-Gilbert deleted the fix/studio-patch-0003-ts branch August 5, 2026 21:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR regenerates the CommonPlace Studio patch 0003 to fix TypeScript build failures introduced by making defaultChatAgent optional in the upstream VS Code surface, and updates the accompanying ledger/report/checklist artifacts to reflect the corrected patch state.

Changes:

  • Fixes TS2345 in chatStatusEntry by guarding the affectsConfiguration(...) call when defaultChatAgent is absent (in patch 0003).
  • Removes the now-unused assertDefined import after onboarding’s module-level defaultChat assert was dropped (in patch 0003).
  • Updates Studio ledger + plan execution artifacts/checklist status to record the failure cause and follow-up state.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packaging/commonplace-studio/patches/0003-retire-default-chat-agent-copilot.patch Adds the missing null/optionality guard in chatStatusEntry and removes the unused onboarding import to unblock TS compilation.
packaging/commonplace-studio/LEDGER.md Records the specific TS failure modes and the patch regeneration rationale.
docs/plans/theorem-chat-register/EXECUTE-REPORT-CR001-CR002.md Adds an execution report capturing the CR-001/CR-002 status and remaining validation steps.
.harness/checklists/theorem-chat-register--plan-local-20260805a.json Updates CR-001/CR-002 statuses to “verifying” and adds artifact evidence notes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +126 to +128
4. Guard `chatStatusEntry`'s `affectsConfiguration(...)` call: optional
`defaultChatAgent` makes `?.completionsEnablementSetting` a
`string | undefined`, which tsgo rejects (TS2345). Narrow before the call.
Plan: `plan-theorem-chat-register-20260805a`

## Summary
- Final condition: [PR #190](https://github.com/Travis-Gilbert/CommonPlace/pull/190) merged; first Studio builds failed on patch-0003 TypeScript (chatStatusEntry `string|undefined`, unused `assertDefined`). Fix regenerating in follow-up PR. Live image is still pre-retirement `706bea01` (old commit SUCCESS) with `WORKSPACE_REPO` set but old entrypoint that does not compose the clone URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants